-
Notifications
You must be signed in to change notification settings - Fork 10
Running sentry tests no longer hits redis rate limit #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will still have issues because of the auth
tests.
Make sure to create a Pool
struct for the tests that will automatically release the Database once the test is done with them.
it should also Flush the Database before releasing it to the pool
sentry - redis pool for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should be enough for our needs atm
closes #357
After some research, I decided to go with the following changes:
SELECT
to switch the Redis DB for each test, making sure tests don't mess it up for one anotherSELECT
I discovered that a common approach is running the tests in the database module sequentially. I used theserial_test
crate for that.