fix(share resume): arial this is system font, and cannot be loaded via google

[DemaPy]

PR Description

Issue

Arial cannot be loaded via Google Fonts (google: { families: ["Arial"] }) because it's a system font, not a web font hosted by Google. Google Fonts only provides web fonts that can be dynamically loaded from their servers, and Arial is a pre-installed system font available on most operating systems (Windows, macOS, Linux).

Summary by CodeRabbit

This update refines how the application handles page load detection, ensuring a more consistent and reliable user experience without altering visible features.

• Refactor
  • Streamlined the page load notification process for improved consistency when pages are fully loaded.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a new function named pageLoadedEvent, which encapsulates the logic for capturing the document’s body dimensions and posting a corresponding message. This function replaces the previously inline implementation. It is invoked from the active callback of the webfontloader.load method and conditionally when the fontString contains "Arial", thereby centralizing the page loaded notification logic.

Changes

File	Change Summary
apps/artboard/.../artboard.tsx	Added a new function pageLoadedEvent to capture the document body dimensions and post a message when the page loads. The inline post message logic was removed and replaced with calls to this function from both the webfontloader.load active callback and a conditional check for "Arial".

Sequence Diagram(s)

sequenceDiagram
    participant Page as ArtboardPage
    participant Loader as webfontloader.load
    participant Event as pageLoadedEvent
    participant Window as Browser Window

    Page->>Loader: Initiate font load
    Loader->>Event: On active callback
    Event->>Window: Post message with document dimensions

    alt Font string contains "Arial"
        Page->>Event: Conditional call for "Arial"
        Event->>Window: Post message with document dimensions
    end

Loading

Poem

I'm a rabbit with a code bouquet,
Hopping through changes in a neat display.
A new function ensures my webpage sings,
Capturing dimensions with joyous flings.
With each post message, I skip with delight,
Celebrating smooth code from morning to night! 🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd21860 and 5b51ac6.

📒 Files selected for processing (1)

• apps/artboard/src/pages/artboard.tsx (2 hunks)

🔇 Additional comments (3)

apps/artboard/src/pages/artboard.tsx (3)

8-13: Good extraction of the page loaded event logic.

Creating a separate function for the page loaded event logic improves code organization and reusability. This extraction helps maintain the DRY principle since this logic is now used in multiple places.

---

31-31: Appropriate use of the extracted function.

The extracted pageLoadedEvent() function is correctly used here to maintain the original functionality while improving code readability.

---

34-37: Good fix for handling Arial as a system font.

This is an excellent fix that addresses the issue with Arial being a system font that cannot be loaded via Google Fonts. By checking for "Arial" in the font string and immediately triggering the page loaded event, you prevent unnecessary waiting for font loading that would never complete.

The early return also properly skips the Google Fonts loading process for Arial, which improves performance by avoiding an unnecessary network request.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DemaPy]

Fix for this issue #2214