Skip to content

Updated idiomatic FastHTML app adv_app.py #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

audreyfeldroy
Copy link
Member


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Updated idiomatic FastHTML app adv_app.py'
labels: 'bug'
assignees: '@audreyfeldroy @Isaac-Flath @pydanny'


Proposed Changes
This is the start of an update to adv_app.py to address:

Request: I noticed adv_app.py isn't really idiomatic. Maybe we should create an idiomatic version of it that uses fast_app, modern routing stuff, avoids fastlite .dataclass(), etc?

To get this out of draft: adv_app.py must be completely updated.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Co-Authored-By: Isaac Flath <[email protected]>
Copy link

gitnotebooks bot commented Mar 27, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/689

@audreyfeldroy audreyfeldroy added the bug Something isn't working label Mar 27, 2025
Co-authored-by: Audrey Roy Greenfeld <[email protected]>
@pydanny
Copy link
Collaborator

pydanny commented Apr 1, 2025

@Isaac-Flath I think we misunderstood your bringing in of your monsterification branch. It appears to reset a number of changes we made to make the PR more idiomatic. This is probably my fault, I told you to bring it in without looking at it.

We could build off your branch, renaming and reconstructing things accordingly. As we're out of time we'll pick up on that tomorrow.

@Isaac-Flath
Copy link
Contributor

Oh sorry it wasn't as helpful as I thought I was being :(. Feel free to revert what I did if that's more helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants