-
Notifications
You must be signed in to change notification settings - Fork 262
Updated idiomatic FastHTML app adv_app.py #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Isaac Flath <[email protected]>
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/689 |
Co-authored-by: Audrey Roy Greenfeld <[email protected]>
Co-authored-by: Audrey Roy Greenfeld <[email protected]>
@Isaac-Flath I think we misunderstood your bringing in of your monsterification branch. It appears to reset a number of changes we made to make the PR more idiomatic. This is probably my fault, I told you to bring it in without looking at it. We could build off your branch, renaming and reconstructing things accordingly. As we're out of time we'll pick up on that tomorrow. |
Oh sorry it wasn't as helpful as I thought I was being :(. Feel free to revert what I did if that's more helpful |
name: Pull Request
about: Propose changes to the codebase
title: '[PR] Updated idiomatic FastHTML app adv_app.py'
labels: 'bug'
assignees: '@audreyfeldroy @Isaac-Flath @pydanny'
Proposed Changes
This is the start of an update to adv_app.py to address:
To get this out of draft: adv_app.py must be completely updated.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply:Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.