-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icon and emoji don't align in the mention page menu. #7673
Conversation
Reviewer's Guide by SourceryThis pull request addresses an alignment issue with icons and emojis in the mention page menu. It introduces an Sequence diagram for rendering InlinePageReference iconsequenceDiagram
participant InlineActionsWidget
participant InlineActionsMenuItem
participant RawEmojiIconWidget
InlineActionsWidget->>InlineActionsMenuItem: item.iconBuilder(isSelected)
activate InlineActionsMenuItem
InlineActionsMenuItem-->>InlineActionsWidget: Widget
deactivate InlineActionsMenuItem
InlineActionsWidget->>RawEmojiIconWidget: RawEmojiIconWidget(emoji, emojiSize, lineHeight)
activate RawEmojiIconWidget
RawEmojiIconWidget-->>InlineActionsWidget: Widget
deactivate RawEmojiIconWidget
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're making a lot of changes to how icons are rendered - can you extract this into a separate widget or helper function?
- Consider using a consistent naming scheme, like
iconBuilder
for all icon-related properties.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
202f3c2
to
1142b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feature Preview
PR Checklist
Summary by Sourcery
Fix icon and emoji alignment in various menu components by standardizing icon sizing and introducing a more flexible iconBuilder method
Bug Fixes:
Enhancements: