-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customize application configuration #7693
Conversation
Reviewer's Guide by SourceryThis pull request introduces a shell script to customize the application configuration for Windows builds, including the application name, identifier, company name, copyright, and icon. It also updates the default binary name in the CMakeLists.txt file. Sequence diagram for customizing Windows application configurationsequenceDiagram
participant S as Shell Script
participant RC as Runner.rc
participant CML as CMakeLists.txt
participant CPP as main.cpp
participant ICO as Icon File
S->>RC: Update CompanyName, FileDescription, InternalName, OriginalFilename, LegalCopyright, ProductName
S->>CML: Update BINARY_NAME
S->>CPP: Update Mutex Name, Window Title, App Link
S->>ICO: Copy new icon
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a rollback mechanism to the script to revert changes in case of errors.
- The script should check if the sed command was successful and exit if it fails.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d3ab621
to
6ec5707
Compare
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | level | link |
---|---|---|---|
Identical pattern | 4 | warning | contribute (via Fink 🐦) |
Missing translation | 136 | warning | contribute (via Fink 🐦) |
2fcf41d
to
a0faeba
Compare
Feature Preview
Allow self-hosters to customize the application information, including the app name, app icon, and application id.
PR Checklist