-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: translations #7694
fix: translations #7694
Conversation
Reviewer's Guide by SourceryThis PR replaces the Sequence diagram for showing toast notification after copying URLsequenceDiagram
participant User
participant Component
participant showToastNotification
User->>Component: Copy URL
Component->>showToastNotification: Display message_copy_success
activate showToastNotification
showToastNotification-->>Component: Notification shown
deactivate showToastNotification
Component-->>User: URL copied notification
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richardshiue - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a constant for
LocaleKeys.message_copy_success
to avoid potential typos and improve maintainability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Update translation tokens for copy success notifications across multiple files
Bug Fixes:
Enhancements: