-
Notifications
You must be signed in to change notification settings - Fork 221
fix: DocumentMarkdownDecoder convert image error when md.Node.Children > 1 and md.Node.Children include img element #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…> 1 and md.Node.Children include img element
Hi, @Linij. Please format your code. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
- Coverage 71.23% 71.22% -0.01%
==========================================
Files 323 323
Lines 15590 15615 +25
==========================================
+ Hits 11105 11122 +17
- Misses 4485 4493 +8 ☔ View full report in Codecov by Sentry. |
@Linij according to the test results, it looks like your fix doesn't cover all the cases. It only generates 5 blocks instead of 6. |
Okay, I will handle it when I have time |
@Linij I’m really looking forward to your updates! However, I’ve noticed a small issue recently where the positions of the images seem to get mixed up after an update—for example, the first image becomes the second. I’ll keep following your updates because this tool is incredibly important to me! Thank you so much for all your hard work! |
-----–––---–––––––––––––––––-----------------------------------

use this text will skip first image, because first element.Children > 1 and include img element.
cause by:
so, this fix code will split all img element from P element.