-
Notifications
You must be signed in to change notification settings - Fork 58
Require external packages only if they are dependencies of the generated binary #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azubieta
wants to merge
1
commit into
main
Choose a base branch
from
fix/cmake_pkg_depends
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,19 @@ | ||
@PACKAGE_INIT@ | ||
|
||
# look up dependencies | ||
find_package(zsync2 REQUIRED) | ||
find_package(libappimage REQUIRED) | ||
find_package(Qt5 REQUIRED COMPONENTS Core Widgets) | ||
set(APPIMAGE_UPDATE_USE_SYSTEM_ZSYNC2 @USE_SYSTEM_ZSYNC2@) | ||
if(APPIMAGE_UPDATE_USE_SYSTEM_ZSYNC2) | ||
find_package(zsync2 REQUIRED) | ||
endif() | ||
|
||
set(APPIMAGE_UPDATE_USE_SYSTEM_LIBAPPIMAGE @USE_SYSTEM_LIBAPPIMAGE@) | ||
if(APPIMAGE_UPDATE_USE_SYSTEM_LIBAPPIMAGE) | ||
find_package(libappimage REQUIRED) | ||
endif() | ||
|
||
set(APPIMAGE_UPDATE_QT_UI @BUILD_QT_UI@) | ||
if(APPIMAGE_UPDATE_QT_UI) | ||
find_package(Qt5 REQUIRED COMPONENTS Core Widgets) | ||
endif() | ||
|
||
include("${CMAKE_CURRENT_LIST_DIR}/AppImageUpdateTargets.cmake") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't even need those temporary variables. Also, as said before, I'm missing some
unset
calls here, and I'd give the variables a prefix.I think using boolean generator expressions, though, we don't need any of these variables:
The expression will be converted to an integer (0 or 1, depending on the value). The advantage of this solution is that the strings in
USE_SYSTEM_ZSYNC2
will not be propagated into a file that is installed later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variables are not meant to be temporary. Instead a would like to inform libappimageupdate clients how it was built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be documented in the
README
then, I guess, and maybe also in this file.Please use the generator expressions to give the variables uniform values.
Also, please remove the underscore between AppImage and Update. The tool is called "AppImageUpdate" without a space.