Skip to content

Update README.md with OpenHarmony build project #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foreveruzi
Copy link

We support build project of OHpro in OpenHarmony, so we'd like to contribute it. Hope my PR can help developers use this library.

Copy link
Collaborator

@christian-rauch christian-rauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

@foreveruzi
Copy link
Author

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

Thank for your suggestion.we will adopt it and make the necessary modifications bedore resubmitting a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants