Forms: Polish integration modal style and copy

[dhasilva]

Fixes FORMS-6

Proposed changes:

• Multiple small tweaks

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to the block editor and add a contact form
• Go to the form integrations modal
• Check that the issues listed here are fixed

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-integration-modal-polishing branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-integration-modal-polishing

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[edanzer]

Lots of small details here. Looks good to me. Thanks @dhasilva!

[CGastrell]

As per issue checklist:

Use #F0F0F0 (scales/gray-100 from the design system). If not available, use the lightest gray available in the current palette

Should we consider this instead of the fixed #f0f0f0?:

border-bottom: 1px solid var(--jp-gray-5, #f0f0f0);

Move badges 10px closer to the header.

Albeit a bit ambiguous, I think just removing the margin-left on the badge should suffice? ie no need to increase the gap on __title-row to 10px (which falls outside of our multiple-of-8 usual units)

[CGastrell]

no need to increase to 10px if we remove the margin-left from the __connected-badge

[dhasilva]

Good points, Christian. I'll merge as-is to do a single deploy with the other PR and we can check with @ilonagl about those points.
About the spacing, you are right about the 8px standard. Figma, however, shows 10px, so we need to check if this is intentional or not.
And the border color, I found that --jp-gray-5 is too light, and since the card component comes from the WorPress components package and already uses a light gray color, then maybe that is the "correct" one?

Both questions deal with use of standards, and that is something we should probably discuss going forward, so thanks for bringing this to our attention.

[ilonagl]

Sorry for being late to the party!

I left a comment in Slack, but in general, let's stick with the standards! You're both absolutely right. 🙌 The Figma designs and comments should be disregarded in that case (I tried to use the standard equivalent in design, but it seems it differs from Figma to code).