Skip to content

e2e tests: attempt to more explicitely start tunnel #43261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 27, 2025

Fixes #43260

Proposed changes:

Let's try to be more explicit in starting the tunnel for the test.

I'm not quite sure why tunnel.js on isn't enough ; let's try to fix that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

@jeherve jeherve self-assigned this Apr 27, 2025
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress Actions GitHub actions used to automate some of the work around releases and repository management [Focus] Performance [Pri] Low labels Apr 27, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@talldan
Copy link
Contributor

talldan commented Apr 28, 2025

This CI job runs the performance tests from the Gutenberg repo?

It looks like you're now hitting upon the same error I encountered in #42934. The REST API utils used in some Gutenberg tests (usually for cleaning up things like posts created during the test) aren't working for some reason in the jetpack environment.

I had some thought's about what the issue might be here - #42934 (comment).

But it still failed after I resolved that (see 8ebb283). I haven't made an issue for this problem yet, I've been sidetracked on some other work.

@jeherve
Copy link
Member Author

jeherve commented May 8, 2025

It looks like you're now hitting upon the same error I encountered in #42934.

Yup, it does indeed seem to be the same problem. @adimoldovan I know Woo also uses @wordpress/e2e-test-utils-playwright. Is that something you've run into in the past, by any chance?

@adimoldovan
Copy link
Member

It looks like you're now hitting upon the same error I encountered in #42934.

Yup, it does indeed seem to be the same problem. @adimoldovan I know Woo also uses @wordpress/e2e-test-utils-playwright. Is that something you've run into in the past, by any chance?

No, sorry, this is the first time I'm seeing this error. I'll try setting up a local env, see if I can find anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Focus] Performance [Pri] Low [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests: fix block performance workflow
3 participants