-
Notifications
You must be signed in to change notification settings - Fork 818
e2e tests: attempt to more explicitely start tunnel #43261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This CI job runs the performance tests from the Gutenberg repo? It looks like you're now hitting upon the same error I encountered in #42934. The REST API utils used in some Gutenberg tests (usually for cleaning up things like posts created during the test) aren't working for some reason in the jetpack environment. I had some thought's about what the issue might be here - #42934 (comment). But it still failed after I resolved that (see 8ebb283). I haven't made an issue for this problem yet, I've been sidetracked on some other work. |
Yup, it does indeed seem to be the same problem. @adimoldovan I know Woo also uses |
No, sorry, this is the first time I'm seeing this error. I'll try setting up a local env, see if I can find anything. |
Fixes #43260
Proposed changes:
Let's try to be more explicit in starting the tunnel for the test.
I'm not quite sure why
tunnel.js on
isn't enough ; let's try to fix that.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: