Skip to content

Labels: update requirements for the "[Type]" labels #43263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Bug Report
description: Report issues with one of our products.
labels: [ 'Needs triage', '[Type] Bug' ]
labels: [ 'Needs triage', 'Bug' ]
type: 'Bug'
body:
- type: markdown
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/report-bugs.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Not mentioned in any of those places? Not caused by a conflict with another plug

### 3. Submit a detailed, precise bug report

The more specific your ticket is, the easier it will be for someone to zap the bug. Log in to GitHub, [open a new issue](https://github.com/Automattic/jetpack/issues/new?assignees=&labels=%5BType%5D+Bug&template=bug-report.yml), and be sure to fill out all the relevant details: a concise summary and a clear description are key. If it's been mentioned by someone else, like on the [Jetpack Support Forums](http://wordpress.org/support/plugin/jetpack), include a link.
The more specific your ticket is, the easier it will be for someone to zap the bug. Log in to GitHub, [open a new issue](https://github.com/Automattic/jetpack/issues/new?assignees=&template=bug-report.yml), and be sure to fill out all the relevant details: a concise summary and a clear description are key. If it's been mentioned by someone else, like on the [Jetpack Support Forums](http://wordpress.org/support/plugin/jetpack), include a link.

Here's a sample of what a helpful summary looks like:

Expand Down
2 changes: 1 addition & 1 deletion docs/release-management.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

For every release, we will have a milestone that contains everything that is slated for that release. <strong>Issues/PRs should not be mass-punted from one release to the next.</strong> When getting punted from a release, issues/PRs should either have their milestone removed completely (from which they will need to be triaged), or they should be put into the "Not Currently Planned" milestone, which is any issue/PR that is valid, but not currently scheduled for inclusion in the point release or the next two major releases.

Any new feature/major bug fix going in gets tagged with "Primary Issue" and either "[Type] Bug Fix", "[Type] Enhancement", "[Type] Janitorial" or "[Type] Feature". Initially, it should be tagged as "[Status] Proposal". If it's something that's absolutely required for this release, it gets tagged "[Priority] Blocker" so we know at a glance that it can't be moved to a future release. It's also tagged with its' area of the plugin as usual. The text of the primary issue should be the proposed implementation, and that text should ALSO be posted as the first comment (more on this in a second)
Any new feature/major bug fix going in gets tagged with "Epic" and either "Bug", "[Type] Enhancement", "[Type] Janitorial" or "[Type] Feature". Initially, it should be tagged as "[Status] Proposal". If it's something that's absolutely required for this release, it gets tagged "[Priority] Blocker" so we know at a glance that it can't be moved to a future release. It's also tagged with its' area of the plugin as usual. The text of the primary issue should be the proposed implementation, and that text should ALSO be posted as the first comment (more on this in a second)

If an issue is fairly involved, it may also make sense to create a GitHub project for it, and that project should be linked to from the “Primary Issue”. Any sub-issues created to track portions of a primary issue should be tagged “Subissue” and refer back to the primary issue # as the first line in the issue body so that they can easily be filtered. Sub-issues should start at "[Status] In Progress".

Expand Down
2 changes: 1 addition & 1 deletion docs/testing/beta-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ Once you've installed and activated the Beta plugin, head over to **Jetpack > Be

## Found a bug?

If you find an issue or have remarks about a Jetpack feature, you can [send us an email](https://jetpack.com/contact-support/beta-group/), or [create an issue on GitHub.](https://github.com/Automattic/Jetpack/issues/new?assignees=&labels=%5BType%5D+Bug&template=bug-report.yml)
If you find an issue or have remarks about a Jetpack feature, you can [send us an email](https://jetpack.com/contact-support/beta-group/), or [create an issue on GitHub.](https://github.com/Automattic/Jetpack/issues/new?assignees=&template=bug-report.yml)

If you’re filing a bug, specific steps to reproduce are helpful. Please include the URL of the page that has the bug, along with what you expected to see and what happened instead. You can [check our recommendations to create great bug reports here](/docs/guides/report-bugs.md).
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Labeling: move from "[Type] Bug" to "Bug" for our label requirements.
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ async function getStatusChecks( payload, octokit ) {
if ( label.match( /^\[Status\].*(?<!Author Reply)$/ ) ) {
acc.hasStatusLabels = true;
}
if ( label.match( /^\[Type\]/ ) ) {
if ( label.match( /^\[Type\]/ ) || label === 'Bug' ) {
acc.hasTypeLabels = true;
}
return acc;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function getIssueType( octokit, owner, repo, number ) {

// Extract type labels, and return them all in a new array, but without the [Type] prefix.
const typeLabels = labels
.filter( label => label.startsWith( '[Type]' ) )
.filter( label => label.startsWith( '[Type]' ) || label === 'Bug' )
.map( label => label.replace( '[Type] ', '' ) );

// If there are multiple types defined in the issue, we cannot extract a specific type.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ async function hasEscalatedLabel( octokit, owner, repo, number, escalatedLabel )
* Send a Slack Notification if the issue is important.
*
* We define an important issue when meeting all of the following criteria:
* - A bug (includes a "[Type] Bug" label, or a "[Type] Bug" label is added to the issue right now)
* - A bug (includes a "Bug" label, or a "Bug" label is added to the issue right now)
* - The issue is still opened
* - The issue is not escalated yet (no label indicating that it was previously escalated to that team)
* - The issue is either a high priority or a blocker (inferred from the existing labels or from the issue body)
Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ On Windows (Vista and later), open an Administrator Command Prompt window and us
Thank you for thinking about contributing to Jetpack! If you're unsure of anything, feel free to submit an issue or pull request on any topic. The worst that can happen is that you'll be politely directed to the best location to ask your question or to change something in your pull request. There are a variety of options for how you can help:

- [Write and submit patches](./docs/CONTRIBUTING.md#write-and-submit-a-patch).
- If you found a bug, [file a report here](https://github.com/Automattic/jetpack/issues/new?assignees=&labels=%5BType%5D+Bug&template=bug-report.yml). You can [check our recommendations to create great bug reports here](./docs/guides/report-bugs.md).
- If you found a bug, [file a report here](https://github.com/Automattic/jetpack/issues/new?assignees=&template=bug-report.yml). You can [check our recommendations to create great bug reports here](./docs/guides/report-bugs.md).
- [Join our Jetpack Beta program](./docs/testing/beta-testing.md) and help us test new releases.
- [Translate Jetpack in your language](./docs/translations.md).

Expand Down
Loading