Update DurableOrchestrationStatus to reference correct history data key from init argument #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toryEvents so it matches [official get instance status response spec(]https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-http-api#response-1)
… showHistory query is true and enclosed unit tests that use query params in getStatus inside a describe block
JPF3N998
changed the title
|
/azp run durable-js.public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@davidmrdavid or @andystaples - wondering if either of you have context enough to know if these changes are safe to accept? The CI seems happy with them, but I'm not super familiar with how good the coverage is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #620
What's new?
According to official docs, orchestration history data is returned on the
historyEventskey inside the response.Current implementation prior to these changes are referencing the
historykey from the response, which doesn't exist leading to settingundefinedon theDurableOrchestrationStatus'shistoryattribute.This PR updates the
DurableORchestrationStatus's constructor to pluck the history data from thehistoryEventskey from theinitconstructor argument and also update the class attributehistoryname tohistoryEventsfor consistency and match the official docs.