-
Notifications
You must be signed in to change notification settings - Fork 4k
[HDInsight] Update api version to 2025-01-15-preview #27837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ayEntraUserInfo ; New-AzHDInsightClusterGatewayEntraUserInfo modify cmd: New-AzHDInsightCluster
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the HDInsight API version to 2025-01-15-preview and adapts the cmdlets, SDK, and tests accordingly. Key changes include:
- Parameter updates in cmdlets to support the new RestAuthEntraUsers input and making HttpCredential optional.
- Updates to test session records and PowerShell scripts to align with the new API version and associated behavior.
- Modifications in the SDK and documentation to reference the updated API endpoints.
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewaySettingsCommand.cs | Adjusted parameter handling and error conditions to support either HttpCredential or RestAuthEntraUsers. |
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterGatewayEntraUserInfoCommand.cs | Added a new cmdlet to create Entra user info objects for gateway access. |
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterCommand.cs | Made HttpCredential optional and added the RestAuthEntraUsers parameter when invoking the cluster creation helper. |
src/HDInsight/HDInsight/ManagementCommands/GetAzureHDInsightClusterGatewayEntraUserInfoCommand.cs | Updated parameter sets to correctly resolve input by name, resource ID, or input object. |
src/HDInsight/HDInsight/Constants.cs | Added a new constant key for EntraUsers under GatewayConfigurations. |
src/HDInsight/HDInsight/ClusterCreateHelper.cs | Updated the method signature to accept RestAuthEntraUsers and added related parameter validation; left some commented-out legacy code. |
Various test and PSD1 files | Updated API version endpoints, cmdlet exports, and test script parameters to reflect the new API version and updated command behavior. |
src/HDInsight/HDInsight.Management.Sdk/Generated/HDInsightManagementClient.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Management.Sdk/Generated/HDInsightManagementClient.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Management.Sdk/Generated/Models/UpdateGatewaySettingsParameters.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAutoscaleTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightClusterTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightClusterTests.cs
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightClusterTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightMonitoringTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight/ChangeLog.md
Outdated
- Added parameter `-EntraUserFullInfo` to cmdlet `New-AzHDInsightCluster` to support creating Entra user clusters using an array of hashtables that include ObjectId, UPN, and DisplayName. | ||
* Added two parameters `-EntraUserIdentity` and `-EntraUserFullInfo` to cmdlet `Set-AzHDInsightGatewayCredential` | ||
- Added parameter `-EntraUserIdentity` to cmdlet `New-AzHDInsightCluster` to support update Entra user clusters using one or more ObjectId or UPNs. Automatically resolves Entra user information. | ||
- Added parameter `-EntraUserFullInfo` to cmdlet `New-AzHDInsightCluster` to support update Entra user clusters using an array of hashtables that include ObjectId, UPN, and DisplayName. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterCommand.cs
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight/help/Add-AzHDInsightComponentVersion.md
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAutoscaleTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightMonitoringTests.ps1
Outdated
Show resolved
Hide resolved
} | ||
catch (Exception ex) | ||
{ | ||
throw new Exception($"Failed to resolve Entra user from input: {data}", ex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could say you can retry or use EntraUserFullInfo way to specify the entra user info
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.