-
Notifications
You must be signed in to change notification settings - Fork 4k
[Az.PurviewData] update generation tool version: autorest.powershell v3 -> v4 #27876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Regenerates the Az.Purview module with autorest.powershell v4, updating cmdlet help, manifest metadata, and the solution configuration.
- Refreshed all
help/*.md
files: removed obsolete-Kind
params, changed parameter types toString
, adjusted output model references, and normalized online URLs. - Updated
Az.Purview.psd1
: bumped generation date, upgradedAz.Accounts
requirement, added newUpdate-*
cmdlets, and fixed path separators. - Revised
Purview.sln
: inserted the newpurviewdata
project entry and expanded solution platform configurations for x64/x86.
Reviewed Changes
Copilot reviewed 401 out of 401 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Purview/Purview/help/*.md | Help topics regenerated: syntax updated, types set to String , output models simplified, URLs lowercased |
src/Purview/Purview/Az.Purview.psd1 | Module manifest bumped date, dependency version, added update cmdlets, path separator normalization |
src/Purview/Purview.sln | Added purviewdata project and x64/x86 Debug/Release configurations |
Comments suppressed due to low confidence (4)
src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md:18
- Switching the file extension parameter from a specific enum type to a plain String[] removes compile-time validation; consider retaining the enum for stricter input validation.
[-ScanningRuleFileExtension <String[]>]
src/Purview/Purview/help/New-AzPurviewAdlsGen1ScanRulesetObject.md:4
- [nitpick] Lowercasing the cmdlet in the online URL may diverge from established URL conventions; verify that the new link resolves correctly and consider matching existing casing patterns.
+online version: https://learn.microsoft.com/powershell/module/Az.Purview/new-azpurviewadlsgen1scanrulesetobject
src/Purview/Purview/Az.Purview.psd1:67
- [nitpick] Using forward slashes in PSD1 paths may not be supported on all platforms; consider using backslashes or a path-building function to ensure cross-platform compatibility.
+FormatsToProcess = 'Purview.Autorest/Az.Purview.format.ps1xml',
src/Purview/Purview/Purview.sln:31
- [nitpick] Adding explicit x64/x86 configurations duplicates the existing Any CPU settings and increases maintenance overhead; consider consolidating or removing redundant solution platforms.
+ Debug|x64 = Debug|x64
src/Purview/Purview/Az.Purview.psd1
Outdated
@@ -51,21 +51,21 @@ DotNetFrameworkVersion = '4.7.2' | |||
# ProcessorArchitecture = '' | |||
|
|||
# Modules that must be imported into the global environment prior to importing this module | |||
RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '4.0.1'; }) | |||
RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '5.0.2'; }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current Az.Accounts version is 5.1.0. Should we also update it here?
… jinpei/main/PurviewData-v4
The service team failed to provide a valid unit test, please ignore the items related to testing.
The content of the changelog is consistent with the PR shared below, so it will be updated in the PR below:
#27871
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.