Skip to content

Az.DNSResolver Additions For 2025-05-01 #27887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jamesvoongms
Copy link
Member

@jamesvoongms jamesvoongms commented Jun 4, 2025

Description

The PR adds the 2025-05-01 changes into a preview branch due to the upcoming breaking changes with BlockResponseCode

Mandatory Checklist

As agreed, this will be public preview despite being a GA version due to the breaking changes with BlockResponseCode

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@jamesvoongms jamesvoongms requested a review from msJinLei June 4, 2025 03:55
@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@jamesvoongms
Copy link
Member Author

One last issue

D:\a_work\1\s\artifacts/StaticAnalysisResults
D:\a_work\1\s\artifacts/StaticAnalysisResults\UXMetadataIssues.csv Errors
"Module","Severity","ResourceType","SubResourceType","Command","Description"
"Az.DnsResolver","1","Microsoft.Network","dnsResolverDomainLists","Invoke-AzDnsResolverBulkDnsResolverDomainList","Cannot find a matched parameter set for example of Invoke-AzDnsResolverBulkDnsResolverDomainList"

I don't see the issue with the example, could someone help take a look at what i am missing?

@vidai-msft
Copy link
Contributor

One last issue

D:\a_work\1\s\artifacts/StaticAnalysisResults D:\a_work\1\s\artifacts/StaticAnalysisResults\UXMetadataIssues.csv Errors "Module","Severity","ResourceType","SubResourceType","Command","Description" "Az.DnsResolver","1","Microsoft.Network","dnsResolverDomainLists","Invoke-AzDnsResolverBulkDnsResolverDomainList","Cannot find a matched parameter set for example of Invoke-AzDnsResolverBulkDnsResolverDomainList"

I don't see the issue with the example, could someone help take a look at what i am missing?

@jamesvoongms We will look into the UX issue and get back.

@vidai-msft
Copy link
Contributor

@jamesvoongms For the UX issue, you can suppress it like the breaking change.

@jamesvoongms
Copy link
Member Author

@vidai-msft , can you help with an azp run? I have added the exclusion

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft enabled auto-merge (squash) June 10, 2025 01:18
@vidai-msft vidai-msft merged commit 34e6eac into Azure:Az.DNSResolver-preview Jun 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants