add new features for Conversation Runtime #33086

amber-ccc · 2025-03-07T21:54:32Z

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

fix #33141

openapi-pipeline-app · 2025-03-07T21:54:36Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-03-07T21:54:36Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

…onRuntime

…ps://github.com/amber-ccc/azure-rest-api-specs into amber/apply_new_feature_for_ConversationRuntime

azure-sdk · 2025-03-12T02:31:03Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
TypeSpec	Language.Conversations
TypeSpec	Language.Text

…the readme

…onRuntime

specification/cognitiveservices/Language.Conversations/models/common.tsp

heaths · 2025-04-09T19:14:18Z

Is this PR actually ready for review now? I've been ignoring it as long as its been in draft, unless you flag me specifically for questions.

amber-ccc · 2025-04-09T19:19:31Z

Yes, this is ready for review now. Let me convert it.

specification/cognitiveservices/Language.AnalyzeText/models/common.models.tsp

mikekistler · 2025-04-10T00:29:15Z

Please address @heaths and @johanste comments and then ping here so I can add the signedOff label.

amber-ccc · 2025-04-10T16:58:59Z

Hi, @heaths , I have updated the code based on your comments, could you pls take a look and let me know? Thank you!

heaths

I assume you've updated the service to match the cancelAfterSeconds?: int32 change as well?

specification/cognitiveservices/Language.Conversations/models/common.tsp

amber-ccc · 2025-04-10T18:23:07Z

Hi @heaths ,
For the change to cancelAfterSeconds?: int32, I just confirmed with my teammates that we received suggestions from the API review board. Since this is just a preview version, we can keep it as cancelAfter?: float32 for now until we get feedback from customers.
So I will restore this changes for now, do you agree with this? Thank you!

heaths · 2025-04-10T18:28:42Z

until we get feedback from customers

I doubt you will, but we provide this feedback to provide consistency and for their benefit. Our guidelines say to put a unit of time/measurement in their to make it self-descriptive.

amber-ccc · 2025-04-10T20:31:59Z

Thanks for your suggestions, @heaths . For this part, I’m not working on the service side—I’m only handling the TypeSpec work based on service-side changes. So, I may need to keep the property as cancelAfter?: float32 to stay consistent with the service.

We’re planning to release GA at the end of April or early May. We will review the customers' feedback and talk about this point again.

amber-ccc · 2025-04-10T21:42:26Z

Hi @mikekistler , I have addressed the comments and health has approved this PR, could you please add the signedOff label if everything looks good? Thank you.

mikekistler

Looks good. 👍

* added new request and response Type * add version information for 2025_05_15 * adjust type to avoid breaking changes * added testing files for conversation runtime 2025-05-15 and modified the readme * revert to Typespec 0.66 version * added comments for Conversations Runtime 2025-05-15 * fixed Typespec validation * restore the base models to previous version and add the new models separately * add test for new feature * adjust the test json for the new feature * adjust the test json * modify the conversationItemIndex to optional * modified the model name * added cancelAfter in AnalyzeConversationJobRequest * add version info for the cancelAfter field * added `cancelAfter` for analyzetext of 2025-05-15-preview * added examples for AnalyzeConversations and AnalyzeText for 2025-05-15-preview * removed AnalyzeText for 2025-05-15 and generated it for version 2025-05-15-preview * modified the readme from 2025-05-15 to 2025-05-15-preview * fix Typespec validation * renamed the 'Conversation' to `AIConversation` * renamed analysisInput and parameters in Request * remove `role` in ConversationalAIItem * removed the `ConversationalAIPrediction` class * modified the `array` to `[ ]` * changed cancelAfter: float to cancelAfterSeconds: int * changed `array` to `[ ]` for version 2025-05-15-preview * restore to 'cancelAfter?: float32;'

added new request and response Type

a6ca994

amber-ccc requested a review from yangyuan as a code owner March 7, 2025 21:54

amber-ccc marked this pull request as draft March 7, 2025 21:54

microsoft-github-policy-service bot added the Cognitive Services label Mar 7, 2025

AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Mar 7, 2025

amber-ccc added the data-plane label Mar 11, 2025

azure-sdk mentioned this pull request Mar 11, 2025

[Cognitive Services Text Analytics API - Azure AI Language] API Review #33141

Closed

Merge branch 'Azure:main' into amber/apply_new_feature_for_Conversati…

e70b04e

…onRuntime

AzureRestAPISpecReview removed the data-plane label Mar 12, 2025

amber-ccc added 2 commits March 11, 2025 19:23

add version information for 2025_05_15

715417c

Merge branch 'amber/apply_new_feature_for_ConversationRuntime' of htt…

12eafc9

…ps://github.com/amber-ccc/azure-rest-api-specs into amber/apply_new_feature_for_ConversationRuntime

azure-sdk mentioned this pull request Mar 12, 2025

[AutoPR Azure.AI.Language.Conversations] add new features for Conversation Runtime azure-sdk/azure-sdk-for-net#10725

Closed

adjust type to avoid breaking changes

9b1b2a0

AzureRestAPISpecReview added the data-plane label Mar 12, 2025

added testing files for conversation runtime 2025-05-15 and modified …

b7e9cf5

…the readme

amber-ccc added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 13, 2025

amber-ccc added 4 commits March 15, 2025 23:23

Merge branch 'Azure:main' into amber/apply_new_feature_for_Conversati…

3589f48

…onRuntime

revert to Typespec 0.66 version

75c1b5f

added comments for Conversations Runtime 2025-05-15

f702155

fixed Typespec validation

fce0fa4

amber-ccc marked this pull request as ready for review March 18, 2025 18:07

amber-ccc requested review from annatisch, heaths, deyaaeldeen, kristapratico, mssfang and joseharriaga as code owners March 18, 2025 18:07

removed the ConversationalAIPrediction class

bf474e1

johanste reviewed Apr 9, 2025

View reviewed changes

specification/cognitiveservices/Language.Conversations/models/common.tsp Outdated Show resolved Hide resolved

amber-ccc marked this pull request as ready for review April 9, 2025 19:19

AzureRestAPISpecReview added the new-api-version label Apr 9, 2025

heaths requested changes Apr 9, 2025

View reviewed changes

specification/cognitiveservices/Language.AnalyzeText/models/common.models.tsp Show resolved Hide resolved

amber-ccc added 2 commits April 9, 2025 19:20

modified the array to [ ]

27d347d

changed cancelAfter: float to cancelAfterSeconds: int

31bff7d

heaths requested changes Apr 10, 2025

View reviewed changes

specification/cognitiveservices/Language.Conversations/models/common.tsp Outdated Show resolved Hide resolved

changed array to [ ] for version 2025-05-15-preview

40c0c95

heaths approved these changes Apr 10, 2025

View reviewed changes

restore to 'cancelAfter?: float32;'

74e9795

mikekistler approved these changes Apr 14, 2025

View reviewed changes

mikekistler added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Apr 14, 2025

yangyuan approved these changes Apr 15, 2025

View reviewed changes

Merge branch 'main' into amber/apply_new_feature_for_ConversationRuntime

d628fc3

AzureRestAPISpecReview added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed new-api-version labels Apr 16, 2025

amber-ccc added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 labels Apr 16, 2025

htokgx approved these changes Apr 16, 2025

View reviewed changes

amber-ccc merged commit 417b5dc into Azure:main Apr 16, 2025
45 of 49 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add new features for Conversation Runtime #33086

add new features for Conversation Runtime #33086

Uh oh!

amber-ccc commented Mar 7, 2025 •

edited by azure-sdk

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 7, 2025 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 7, 2025 •

edited

Loading

Uh oh!

azure-sdk commented Mar 12, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

heaths commented Apr 9, 2025

Uh oh!

amber-ccc commented Apr 9, 2025

Uh oh!

Uh oh!

mikekistler commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025

Uh oh!

heaths left a comment

Uh oh!

Uh oh!

amber-ccc commented Apr 10, 2025 •

edited

Loading

Uh oh!

heaths commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025 •

edited

Loading

Uh oh!

mikekistler left a comment

Uh oh!

Uh oh!

Uh oh!

add new features for Conversation Runtime #33086

add new features for Conversation Runtime #33086

Uh oh!

Conversation

amber-ccc commented Mar 7, 2025 • edited by azure-sdk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a PR Template

Uh oh!

openapi-pipeline-app bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-sdk commented Mar 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

Uh oh!

heaths commented Apr 9, 2025

Uh oh!

amber-ccc commented Apr 9, 2025

Uh oh!

Uh oh!

mikekistler commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amber-ccc commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heaths commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025

Uh oh!

amber-ccc commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikekistler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amber-ccc commented Mar 7, 2025 •

edited by azure-sdk

Loading

openapi-pipeline-app bot commented Mar 7, 2025 •

edited

Loading

openapi-pipeline-app bot commented Mar 7, 2025 •

edited

Loading

azure-sdk commented Mar 12, 2025 •

edited by github-actions bot

Loading

amber-ccc commented Apr 10, 2025 •

edited

Loading

amber-ccc commented Apr 10, 2025 •

edited

Loading