Initialize a Rush workspace for client SDKs #2047

bsiegel · 2019-04-05T23:35:16Z

This PR creates a new Rush workspace, currently only containing the client SDKs. It includes several dependency version updates to align them across projects - this way, Rush can ensure that dependency versions for all of our packages remain in sync going forward.

Rush is configured to use pnpm as the package manager which provides several additional benefits. However Rush is not 100% compatible with the current version of pnpm (v3) so we should hold off merging this until that compatibility is added, or roll back to v2 of pnpm in rush.json

weshaggard · 2019-04-08T17:16:58Z

cc @Azure/azure-sdk-eng

bterlson · 2019-04-19T21:26:22Z

Some notes:

main key of rollup-plugin-node-resolve is deprecated. Use mainFields instead.
Seems like we have multiple versions of TypeScript. Probably not a major issue for now.
rush test rebuilds the world after a rush build. Is this expected?
rush add should really allow me to add local, unpublished packages (see: [rush] "rush add" should be able to add unpublished locally-linked projects microsoft/rushstack#991)
Instructions for taking an unpublished dependency seems important. Process is, basically, manually update your package.json with the dependency and run rush update.
VSCode seems to stomp on some things, resulting in permissions errors when doing e.g. rush update. I suspect it's automatic type acquisition. I think I've gotten to a good place by enabling "typescript.disableAutomaticTypeAcquisition" in my workspace, might be worth adding that suggestion to the readme.

bterlson · 2019-04-19T22:01:10Z

Played around with this (and built on it with #2373) and I like it lots. Happy to see this merged ASAP so we can start more refactorings like #2373.

bsiegel · 2019-04-22T22:21:36Z

main key of rollup-plugin-node-resolve is deprecated. Use mainFields instead.

Fixed.

Seems like we have multiple versions of TypeScript. Probably not a major issue for now.

This was always true. API Extractor v6 requires an old version. If we upgrade to v7 it will resolve this issue.

rush test rebuilds the world after a rush build. Is this expected?

No, it's because we have many packages where the "test" script runs "build". We should clean this up in a followup PR.

rush add should really allow me to add local, unpublished packages (see: Microsoft/web-build-tools#991)

😿 but for what it's worth you can edit the package.json manually and do rush update in this situation.

Instructions for taking an unpublished dependency seems important. Process is, basically, manually update your package.json with the dependency and run rush update.

Good catch! Fixed.

VSCode seems to stomp on some things, resulting in permissions errors when doing e.g. rush update. I suspect it's automatic type acquisition. I think I've gotten to a good place by enabling "typescript.disableAutomaticTypeAcquisition" in my workspace, might be worth adding that suggestion to the readme.

Added to the README. What are your feelings on checking in the .vscode/settings.json file with this change? I can see other settings being appropriate to commit as well, to help enforce some things repo-wide. If we want to make sure people don't keep getting diffs by making settings changes to their local workspace, we can keep the file .gitignored and force-add it to the working tree.

bterlson · 2019-04-22T22:56:42Z

I have a vague worry that there are other things in vscode doing npm install for you, but talking with @ramya-rao-a this may be the only place. I like disabling it in settings.json. I also kinda like the hack you mention to allow updating of local settings! It lets me configure my extensions I love that nobody else has 😊 But, I'll leave that up to you, I'm ok dealing with untracked changes as well.

mikeharder

A few general questions:

Should the Azure Pipelines YAML be updated to use the Rush commands for building, testing, etc?
How does build and test performance compare between the current "npm-run-all" solution and Rush? What, if anything, does Rush improve with respect to developer experience, either inner loop (incremental compilation) or outer loop (full compilation)?

common/scripts/rush-welcome.js

common/scripts/sync-versions.js

gulpfile.ts

sdk/eventhub/event-hubs/package.json

sdk/eventhub/event-processor-host/package.json

sdk/eventhub/testhub/commands/sendReceive.ts

sdk/eventhub/testhub/package.json

sdk/keyvault/keyvault/package.json

sdk/servicebus/service-bus/package.json

bterlson · 2019-04-23T18:34:49Z

FWIW, my experience is full builds are much faster as it seems to skip things that are already built.

mikeharder · 2019-04-23T18:38:35Z

FWIW, my experience is full builds are much faster as it seems to skip things that are already built.

I will run a few before/after perf tests.

bsiegel · 2019-04-23T21:14:06Z

Should the Azure Pipelines YAML be updated to use the Rush commands for building, testing, etc?

Yep, I am planning to do that in a followup PR.

The plugin can't resolve correctly when the dependency inside node_modules is a symlink rather than a regular directory. Update the configs to use the new 'mainFields' option and exclude 'main' from the list of fields to work around this.

weshaggard · 2019-04-30T19:49:36Z

common/config/rush/command-line.json

@@ -0,0 +1,278 @@
+/**


Sorry I accidentally posted this to another PR, not sure what happened, and I know this is already merged but I'm still curious about my question below.

Is there any hard rules about these files going into a folder called common? I ask mostly as for some of the other languages we have been putting similar engineering system type files under an "eng" directory.

bsiegel force-pushed the rush_init branch 2 times, most recently from 397392f to 8c275db Compare April 11, 2019 23:22

bsiegel force-pushed the rush_init branch 11 times, most recently from 44b2e5a to faa5885 Compare April 18, 2019 23:05

bterlson mentioned this pull request Apr 19, 2019

Abstract aborter into its own library #2373

Closed

bsiegel force-pushed the rush_init branch from faa5885 to 402b553 Compare April 22, 2019 22:21

bsiegel force-pushed the rush_init branch 2 times, most recently from 14f99ea to c7a893d Compare April 22, 2019 23:40

mikeharder requested changes Apr 23, 2019

View reviewed changes

bsiegel force-pushed the rush_init branch from c7a893d to 110a6e8 Compare April 23, 2019 21:03

bsiegel force-pushed the rush_init branch 3 times, most recently from 31c4e0b to 8fdbcee Compare April 25, 2019 00:01

mikeharder approved these changes Apr 25, 2019

View reviewed changes

bsiegel force-pushed the rush_init branch 2 times, most recently from eb7d3b3 to 8aeffa1 Compare April 26, 2019 22:30

Brandon Siegel added 12 commits April 29, 2019 11:14

Initialize Rush repo

a2ad3a8

Remove project-specific files

d3e13b3

Align dependency versions

293b58c

Add non-shipping projects

ac6ff60

Hack around rollup-plugin-node-resolve bug #94

cd874e0

The plugin can't resolve correctly when the dependency inside node_modules is a symlink rather than a regular directory. Update the configs to use the new 'mainFields' option and exclude 'main' from the list of fields to work around this.

Add Rush project commands for testing

7b8ca19

Standardize client script tasks

128c033

Add sync-versions command

6080388

Expose Prettier commands to Rush

5a105e5

Add Rush documentation

e0d7e66

Add reset-workspace command

78e2e5e

Enable running npm audit via Rush

b704334

bsiegel force-pushed the rush_init branch from 8aeffa1 to b704334 Compare April 29, 2019 18:16

bsiegel merged commit 0087296 into master Apr 29, 2019

bsiegel deleted the rush_init branch April 29, 2019 18:57

weshaggard reviewed Apr 30, 2019

View reviewed changes

HarshaNalluru mentioned this pull request May 1, 2019

[Storage] Update live test command for storage packages #2616

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initialize a Rush workspace for client SDKs #2047

Initialize a Rush workspace for client SDKs #2047

Uh oh!

bsiegel commented Apr 5, 2019

Uh oh!

weshaggard commented Apr 8, 2019

Uh oh!

bterlson commented Apr 19, 2019

Uh oh!

bterlson commented Apr 19, 2019

Uh oh!

bsiegel commented Apr 22, 2019 •

edited

Loading

Uh oh!

bterlson commented Apr 22, 2019

Uh oh!

mikeharder left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bterlson commented Apr 23, 2019

Uh oh!

mikeharder commented Apr 23, 2019

Uh oh!

bsiegel commented Apr 23, 2019

Uh oh!

weshaggard Apr 30, 2019

Uh oh!

Uh oh!

Initialize a Rush workspace for client SDKs #2047

Initialize a Rush workspace for client SDKs #2047

Uh oh!

Conversation

bsiegel commented Apr 5, 2019

Uh oh!

weshaggard commented Apr 8, 2019

Uh oh!

bterlson commented Apr 19, 2019

Uh oh!

bterlson commented Apr 19, 2019

Uh oh!

bsiegel commented Apr 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bterlson commented Apr 22, 2019

Uh oh!

mikeharder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bterlson commented Apr 23, 2019

Uh oh!

mikeharder commented Apr 23, 2019

Uh oh!

bsiegel commented Apr 23, 2019

Uh oh!

weshaggard Apr 30, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bsiegel commented Apr 22, 2019 •

edited

Loading