[Core] Wiring up rehydration token logic in data-plane #49224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
kinelski
commented
Apr 3, 2025
Comment on lines
+34
to
+42
| public override RehydrationToken? GetRehydrationToken() | ||
| { | ||
| if (_nextLinkOperation is NextLinkOperationImplementation nextLinkOperation) | ||
| { | ||
| return nextLinkOperation?.GetRehydrationToken(); | ||
| } | ||
|
|
||
| return null; | ||
| } |
There was a problem hiding this comment.
Supposedly _nextLinkOperation will always be a NextLinkOperationImplementation instance in data-plane. I didn't want to force a cast here to avoid throwing in unpredicted scenarios. Before this change, GetRehydrationToken would always return null anyway.
|
API change check API changes are not detected in this pull request. |
jsquire
reviewed
Apr 4, 2025
There was a problem hiding this comment.
Looks fine to me, but I'll ask that @JoshLove-msft and @m-nash be the authoritative approvals here, as there are generator and management plane implications.
m-nash
reviewed
Apr 12, 2025
| @@ -30,6 +30,17 @@ internal ProtocolOperation(ClientDiagnostics clientDiagnostics, HttpPipeline pip | |||
| public override string Id => throw new NotSupportedException(); | |||
| #pragma warning restore CA1822 | |||
|
|
|||
| /// <inheritdoc /> | |||
| public override RehydrationToken? GetRehydrationToken() | |||
There was a problem hiding this comment.
I wonder if this should be added to the OperationState so that all operation types pick up the new changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DPG libraries do not support rehydrating long-running operations. This means that, after a long-running operation has been started, users must hold their
Operation<T>reference until its completion in order to access its final result. This can be a problem as some operations could take hours or even days to complete.Our TypeSpec code generator already supports the creation of rehydration tokens to retrieve the status of long-running operations, but the logic to do so had not been wired into our
OperationAPI yet.Fixes #48594.