[Storage][DataMovement] NFS File-to-File Copy Transfer Preservation #49266
+370
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickliu-msft
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft and
jalauzon-msft
as code owners
nickliu-msft
changed the title
nickliu-msft
commented
Apr 7, 2025
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/ShareFileStorageResource.cs
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
nickliu-msft
commented
Apr 8, 2025
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/ShareFileStorageResource.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs
Outdated
Show resolved
Hide resolved
...zure.Storage.DataMovement.Files.Shares/api/Azure.Storage.DataMovement.Files.Shares.net6.0.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/tests/Shared/DisposingShare.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.Shares/src/Models/ShareFileProperties.cs
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Apr 10, 2025
amnguye
reviewed
Apr 16, 2025
| <PackageReference Include="Azure.Storage.Files.Shares" /> | ||
| <!--<ProjectReference Include="$(MSBuildThisFileDirectory)..\..\Azure.Storage.Files.Shares\src\Azure.Storage.Files.Shares.csproj" />--> | ||
| <!-- <PackageReference Include="Azure.Storage.Files.Shares" /> --> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\..\Azure.Storage.Files.Shares\src\Azure.Storage.Files.Shares.csproj" /> |
There was a problem hiding this comment.
Is there a github issue made to track to ensure that the Azure.Storage.Files.Storage package gets released first before DMLib (or at the same time). IIRC the base storage SDK packages are released in a separate pipeline than DataMovement now. So a github issue may need to be made to remember to revert this change back before release.
amnguye
reviewed
Apr 16, 2025
sdk/storage/Azure.Storage.DataMovement.Files.Shares/tests/ShareFileResourceTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for NFS File-to-File copy transfer. Future works will include Directory-Directory Copy and Uploads and Downloads.
"For NFS service-to-service copy, we need to not set the SMB-specific properties, set the NFS-specific properties, and preserve permissions based on ShareFileStorageResourceOptions.FilePermission."