Skip to content

Recovery service backup stable 2025-04-01. 2025-April release with support for ASEBackup. #49275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 14, 2025
Merged

Recovery service backup stable 2025-04-01. 2025-April release with support for ASEBackup. #49275

merged 18 commits into from
Apr 14, 2025

Conversation

vikramkotturu
Copy link
Member

Recovery service backup stable 2025-04-01. 2025-April release with support for ASEBackup.

Swagger approval PR Azure/azure-rest-api-specs#32507

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Recovery Services Backup labels Apr 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

Thank you for your contribution @vikramkotturu! We will review the pull request and get back to you soon.

jsquire
jsquire previously requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikramkotturu:

Your account lacks the public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@vikramkotturu
Copy link
Member Author

Validate-AzsdkCodeOwner

Addressed these I think there is a delay in reflection of permissions, will cross check the script in a little later.

ArcturusZhang
ArcturusZhang reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few build errors therefore we must resolve them first and then please run <RepoRoot>/eng/scripts/Export-API.ps1 <your service directory> command to generate the API files.

I have briefly described how rename-mapping works, for more details, you could refer to the doc here: https://github.com/Azure/autorest.csharp/blob/main/docs/mgmt/polishing.md#rename-a-type

@vikramkotturu
Copy link
Member Author

We have a few build errors therefore we must resolve them first and then please run <RepoRoot>/eng/scripts/Export-API.ps1 <your service directory> command to generate the API files.

I have briefly described how rename-mapping works, for more details, you could refer to the doc here: https://github.com/Azure/autorest.csharp/blob/main/docs/mgmt/polishing.md#rename-a-type

Made this correction and pushed the changes.

@jsquire
Copy link
Member

jsquire commented Apr 9, 2025 •
edited
Loading

Validate-AzsdkCodeOwner

Addressed these I think there is a delay in reflection of permissions, will cross check the script in a little later.

Rechecked, and you're clear now. Unless you have an arrangement with Arthur's team, please add yourself to the management section of CODEOWNERS.

@jsquire jsquire removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels Apr 9, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.RecoveryServicesBackup

@ArcturusZhang
Copy link
Member

Please update the changelog with a brief of your changes and a desired release date.

@vikramkotturu
Copy link
Member Author

Validate-AzsdkCodeOwner

Addressed these I think there is a delay in reflection of permissions, will cross check the script in a little later.

Rechecked, and you're clear now. Unless you have an arrangement with Arthur's team, please add yourself to the management section of CODEOWNERS.

Yes we are working with Arthur's team

@jsquire jsquire dismissed their stale review April 11, 2025 15:35

Account configuration fixed.

@vikramkotturu
Copy link
Member Author

Please update the changelog with a brief of your changes and a desired release date.

done

@vikramkotturu vikramkotturu merged commit 34fc134 into Azure:main Apr 14, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@jsquire jsquire Awaiting requested review from jsquire

Assignees
No one assigned
Labels
Recovery Services Backup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikramkotturu @jsquire @azure-sdk @ArcturusZhang