Skip to content

Neon GA release dotnet SDK #49390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
May 9, 2025
Merged

Neon GA release dotnet SDK #49390

merged 44 commits into from
May 9, 2025

Conversation

alluri02
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 14, 2025 •
edited by github-actions bot
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.NeonPostgres

@alluri02 alluri02 marked this pull request as ready for review April 14, 2025 09:37
@alluri02
Copy link
Member Author

#49211 (comment)

"These are not ARM IDs; these IDs are returned by the Partner API. For example: org-autumn-queen-14745070, ancient-moon-78735937, etc."

@alluri02
Copy link
Member Author

#49211 (comment)

Our team develops integrations for third-party ISV partners in the Azure Marketplace. In most cases, the naming conventions are driven by the partners themselves to ensure consistency and familiarity for end users.

jsquire
jsquire previously requested changes Apr 14, 2025
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alluri02:

Your account lacks the public GitHub organization memberships for "Azure" and "Microsoft" required of an internal contributor. (You have these memberships, but you've marked them private.)
Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@alluri02 alluri02 requested a review from a team as a code owner April 15, 2025 08:48
@alluri02
Copy link
Member Author

@alluri02:

Your account lacks the public GitHub organization memberships for "Azure" and "Microsoft" required of an internal contributor. (You have these memberships, but you've marked them private.) Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Done

@jsquire jsquire dismissed their stale review April 15, 2025 16:00

Account issues confirmed resolved.

@alluri02
Copy link
Member Author

#49211 (review)

As per this comment, I have raised the PR in the Public Spec - Azure/azure-rest-api-specs#34043

@alluri02 alluri02 requested a review from aggarwalsw as a code owner May 4, 2025 05:52
jsquire
jsquire reviewed May 6, 2025
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed May 9, 2025
View reviewed changes
@ArcturusZhang ArcturusZhang merged commit bbf5714 into Azure:main May 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire left review comments

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@aggarwalsw aggarwalsw Awaiting requested review from aggarwalsw

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl

@trrwilson trrwilson Awaiting requested review from trrwilson

@joseharriaga joseharriaga Awaiting requested review from joseharriaga

@m-nash m-nash Awaiting requested review from m-nash

@ralph-msft ralph-msft Awaiting requested review from ralph-msft

Assignees
No one assigned
Labels
Neon Postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alluri02 @azure-sdk @jsquire @ArcturusZhang