Skip to content

Create ListDatabases resource #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

yoshuawuyts
Copy link
Contributor

This converts the "list database" operations from the older req/res-style API into the newer pipeline-based API (ref: #290). Thanks!

cc/ @rylev

This converts from the older req/res-style API into the newer pipeline-based API (ref: Azure#290).
@yoshuawuyts yoshuawuyts force-pushed the list-databases-new-arch branch from 4bda4dd to ad4e3c9 Compare August 3, 2021 14:32
@rylev rylev self-requested a review August 3, 2021 14:34
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! 🎉In the interest of getting things rolling, I'm going to merge this, but we should add streaming capability back in ASAP. We just need to decide what the stream API looks like in the architecture.

Ok(())
}

// pub fn stream(&self) -> impl Stream<Item = Result<ListDatabasesResponse, crate::Error>> + '_ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to figure out what our interface for kicking off an async iterator response will be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 yess, will do as a follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants