support mutliple Scopes in client credential flow #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following both the existing rust DeviceCode model, as well as MSAL for Python and MSAL for Net, allow requesting multiple scopes at once from confidential clients. Both in documentation and in practice, scopes are space-separated list of permissions. ref: https://docs.microsoft.com/en-us/dotnet/api/microsoft.identity.client.iconfidentialclientapplication.acquiretokenbyauthorizationcode?view=azure-dotnet#parameters ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/sample/confidential_client_secret_sample.py#L7 ref: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#requesting-individual-user-consent ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/45499ff5a4ba1afbb71ed95aa5491f924f39dbba/msal/oauth2cli/oauth2.py#L180 ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/45499ff5a4ba1afbb71ed95aa5491f924f39dbba/msal/oauth2cli/oauth2.py#L265-L268
cataggar
approved these changes
Nov 3, 2021
|
Note, this doesn't fix #61. The Token Credential stuff still takes a |
rylev
approved these changes
Nov 3, 2021
bmc-msft
deleted the
support-multiple-scopes-in-client-credential-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following both the existing rust DeviceCode model, as well as MSAL for Python and MSAL for Net, allow requesting multiple scopes at once from confidential clients.
Both in documentation and in practice, scopes are space-separated list of permissions.
ref: https://docs.microsoft.com/en-us/dotnet/api/microsoft.identity.client.iconfidentialclientapplication.acquiretokenbyauthorizationcode?view=azure-dotnet#parameters
ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/dev/sample/confidential_client_secret_sample.py#L7
ref: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-permissions-and-consent#requesting-individual-user-consent
ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/45499ff5a4ba1afbb71ed95aa5491f924f39dbba/msal/oauth2cli/oauth2.py#L180
ref: https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/45499ff5a4ba1afbb71ed95aa5491f924f39dbba/msal/oauth2cli/oauth2.py#L265-L268