Skip to content

Add more data_lake operations #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 9, 2021
Merged

Add more data_lake operations #495

merged 16 commits into from
Nov 9, 2021

Conversation

thovoll
Copy link
Contributor

@thovoll thovoll commented Nov 6, 2021

@thovoll thovoll mentioned this pull request Nov 7, 2021
Closed
34 tasks
@thovoll thovoll changed the title Add "append to file" operation to data_lake Add more data_lake operations Nov 7, 2021
@thovoll thovoll requested review from rylev and MindFlavor November 8, 2021 05:04
@thovoll thovoll marked this pull request as ready for review November 8, 2021 05:22
rylev
rylev reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd prefer if we could have some mock testing framework tests that verify that this works though

@thovoll thovoll requested a review from rylev November 9, 2021 02:00
@thovoll
Copy link
Contributor Author

thovoll commented Nov 9, 2021

@rylev I addressed your feedback, this should be ready to go!

rylev
rylev approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rylev rylev merged commit 8edf216 into Azure:main Nov 9, 2021
@thovoll thovoll deleted the data_lake/update_path branch November 9, 2021 13:53
@thovoll thovoll mentioned this pull request Nov 9, 2021
Closed
@thovoll thovoll added the Data Lake Data Lake Storage label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

@MindFlavor MindFlavor Awaiting requested review from MindFlavor

Assignees
No one assigned
Labels
Data Lake Data Lake Storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thovoll @rylev