use TokenCredential in services #59
Conversation
| @@ -34,7 +34,7 @@ async-trait = "0.1.36" | |||
| oauth2 = { version = "4.0.0-alpha.2" } | |||
|
|
|||
| [dev-dependencies] | |||
| tokio = "0.3" | |||
| tokio = "0.2" | |||
There was a problem hiding this comment.
I got some runtime errors regarding the hyper dependency. I think we may need to wait for hyper to upgrade.
There was a problem hiding this comment.
- hyper v0.14 Upgrade to Tokio v0.3 hyperium/hyper#2302
- reqwest ? Update
tokioto 1.0 seanmonstar/reqwest#1060
There was a problem hiding this comment.
I created #60 to track upgrading.
services/mgmt/resources/src/lib.rs
Outdated
| pub bearer_access_token: Option<String>, | ||
| pub bearer_access_token: Option<String>, // TODO remove | ||
| pub token_credential: Option<Box<dyn azure_core::TokenCredential>>, | ||
| pub token_credential_scope: String, |
There was a problem hiding this comment.
Shouldn't it be a list of scopes?
https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-acquire-cache-tokens#scopes-when-acquiring-tokens
For v2.0, it is still in the scope http query param, but it is a space separated list. Let's looks and see what other SDKs do.
There was a problem hiding this comment.
I added an issue to review this in the not too distant future: #61
|
It may be easiest to review the AutoRust changes for this in ctaggart/autorust#69. |
|
@rylev, can I get an approval of this one? |
Please review for #53. I made these changes manually to update
cargo run --example group_createso that it works withTokenCredential. Once we figure out the design, I'll update the AutoRust code gen.