drop as_ prefix from as_X_client from storage crates #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in Azure#676, this renames the various as_X_client to X_client
cataggar
approved these changes
Jun 23, 2022
rylev
approved these changes
Jun 23, 2022
| storage_account | ||
| .as_table_service_client() | ||
| .table_service_client() |
There was a problem hiding this comment.
Shouldn't this just be table_client? What's the benefit of the service nomenclature?
There was a problem hiding this comment.
One of the things that could stand clearing up is this issue. I understand the underlying intent in this implementation, but it's confusing. Currently, with a StorageAccount.table_service_client gets you a TableServiceClient.
TableServiceClient lets you:
- list tables
- get a TableClient for a specified table.
TableClient lets you interact with a given table (create it, query it, delete it, insert things into it, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #676, this renames the various as_X_client to X_client