[datalake] add missing file and directory methods #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
commented
Jun 25, 2022
Comment on lines
+17
to
+21
| impl From<BTreeMap<Cow<'static, str>, Cow<'static, str>>> for Properties { | ||
| fn from(value: BTreeMap<Cow<'static, str>, Cow<'static, str>>) -> Self { | ||
| Self(value) | ||
| } | ||
| } |
There was a problem hiding this comment.
Thought about providing a more flexible implementation, like
impl<T> From<T> for Properties
where
T: Into<BTreeMap<Cow<'static, str>, Cow<'static, str>>>,
{
fn from(value: T) -> Self {
Self(value.into())
}
}however that conflicts with the TryFrom<&Headers> implementation, which needs to look into a specific header key. Not sure if this is that important here, but maybe we can remove the conflicting trait implementations since they are used to convert responses - i.e. no added convenience for the user - vs. adding convenience in the user facing methods...
cataggar
approved these changes
Jul 5, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the last remaining methods to the file and directory clients.
From what I can tell the last missing functionality is leases, but I left those for a follow-up PR, since they seem to be usually implemented using a dedicated client.
towards #802, #496