Skip to content

Multiple Instances in MSAL Pt. 2: Further improvements to cache strategy #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from

Conversation

pkanher617
Copy link
Contributor

This PR is to make sure we cache nonce with the state parameter to ensure that there are no inadvertent mismatches.

@pkanher617 pkanher617 changed the title Add State to Nonce to ensure correct checking of parameters Multiple Instances in MSAL Pt. 2: Further improvements to cache strategy Sep 19, 2019
@pkanher617 pkanher617 requested a review from sameerag September 19, 2019 00:31
@pkanher617 pkanher617 self-assigned this Sep 19, 2019
@DarylThayil DarylThayil added this to the October 2019 milestone Sep 19, 2019
@sameerag sameerag changed the base branch from iframes_authRedirect to multiple-instances September 24, 2019 21:05
@sameerag sameerag changed the base branch from multiple-instances to iframes_authRedirect September 24, 2019 21:05
@sameerag sameerag changed the base branch from iframes_authRedirect to dev October 2, 2019 18:09
@sameerag sameerag changed the base branch from dev to iframes_authRedirect October 2, 2019 19:10
@sameerag sameerag changed the base branch from iframes_authRedirect to dev October 2, 2019 19:12
@sameerag sameerag changed the base branch from dev to multiple-instances October 2, 2019 19:16
@sameerag sameerag changed the base branch from multiple-instances to msal-multiple-instances October 2, 2019 19:48
@sameerag sameerag changed the base branch from msal-multiple-instances to multiple-instances October 2, 2019 19:49
@pkanher617
Copy link
Contributor Author

No longer required - work was done in PR #1010

@pkanher617 pkanher617 closed this Oct 15, 2019
@sameerag sameerag deleted the state-keyed-cache branch November 11, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants