Dockerize CloudFoxable #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Windows Compatibility: Users running the tool on Windows may encounter issues with certain challenges (e.g., Wyatt, Search, The Topic is Exposure) when using the local-exec provisioner in Terraform. The goal of this update is to allow users to containerize the application to ensure smooth execution of the Terraform code without issues. By doing so, users can mount both the AWS credentials file and the cloudfoxable/aws folder to maintain persistence. This ensures that the AWS credentials file doesn’t need to be recreated each time the container is restarted. Additionally, mounting the cloudfoxable/aws folder allows for modifications to the terraform.tfvars file and ensures that the Terraform state file is written to the host system.
Policy Format Change: I’ve replaced the <<POLICY heredoc notation with jsonencode in Terraform to address issues caused by the former format. This ensures proper handling of the policy as a JSON object.
IP Address Source Update: The external IP address source has been changed from https://ifconfig.me to https://api.ipify.org. The previous source could return more than just the IP address (i.e. HTML) and https://ifconfig.me/ip could return an IPv6 address, which is not universally supported. Using https://api.ipify.org ensures that only the correct IP (IPV4) address is returned.
Hope this helps!