eth: migrate etherscan API to v2 #3321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested changes
May 5, 2025
backend/backend.go
Outdated
| @@ -517,19 +517,19 @@ func (backend *Backend) Coin(code coinpkg.Code) (coinpkg.Coin, error) { | |||
| coin = btc.NewCoin(coinpkg.CodeLTC, "Litecoin", "LTC", coinpkg.BtcUnitDefault, <c.MainNetParams, dbFolder, servers, | |||
| "https://blockchair.com/litecoin/transaction/", backend.socksProxy) | |||
| case code == coinpkg.CodeETH: | |||
| etherScan := etherscan.NewEtherScan("https://api.etherscan.io/api", backend.etherScanHTTPClient) | |||
| etherScan := etherscan.NewEtherScan("https://api.etherscan.io/v2/api?chainid=1", backend.etherScanHTTPClient) | |||
There was a problem hiding this comment.
I think it's more proper to encode the chainID as a param in the call() function and not pass it as part of the url in here. In fact, you can drop the base url param as it's now the same for all. Rather, pass the chainID as an argument.
There was a problem hiding this comment.
ahahah, I knew you'd want to do it that way :D
There was a problem hiding this comment.
😂 It's not the first time you say this either 😂
There was a problem hiding this comment.
I changed it a few days ago btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.