Skip to content

frontend: convert utils/equal in typescript #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thisconnect
Copy link
Collaborator

No description provided.

Simplifying so that TypeScript better understand the code and we
can change from any to unknown in the future.
@thisconnect thisconnect requested review from shonsirsha and removed request for shonsirsha May 13, 2025 07:04
@thisconnect thisconnect marked this pull request as draft May 13, 2025 07:32
@thisconnect thisconnect force-pushed the frontend-utilsequal-in-typescript branch 2 times, most recently from cdaf010 to 23a4c21 Compare May 13, 2025 08:44
Using `unknown` enforces type safety by requiring explicit type
checks or assertions before performing operations on the values.

Also updated `Object.keys` usage with a more precise type assertion
to satisfy TypeScript's stricter checks when working with `unknown`.

This version now also supports date and regexp.
@thisconnect thisconnect force-pushed the frontend-utilsequal-in-typescript branch from 23a4c21 to b85f8d1 Compare May 13, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant