frontend: show device picker when prompted to connect keystore #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an account in watch-only mode without a device connected, there is a prompt to connect the device when trying to verify a receive address, sign a transaction, or anything that needs the BitBox device. With a USB connection that works as the app automatically connects to it. with Bluetooth, for a device that has not been connected before (so it does not auto-connect), the user will be stuck, as the Bluetooth scanner component is not visible there. This commit adds the scanner component there.
|
@benma partly tested LGTM but is this still in draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an account in watch-only mode without a device connected, there is a prompt to connect the device when trying to verify a receive address, sign a transaction, or anything that needs the BitBox device. With a USB connection that works as the app automatically connects to it. with Bluetooth, for a device that has not been connected before (so it does not auto-connect), the user will be stuck, as the Bluetooth scanner component is not visible there.
This commit adds the scanner component there.