Skip to content

make noise pairing confirmation optional over BLE #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: staging/ble
Choose a base branch
from
Open

make noise pairing confirmation optional over BLE #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rust/bitbox02-rust/src/hww/noise.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ pub(crate) async fn process(
bitbox02_noise::HandshakeResult::Done => {
let already_verified =
memory::check_noise_remote_static_pubkey(&state.remote_static_pubkey()?);
if already_verified {
// When communicating over BLE, we don't require noise pairing code
// confirmation, as BLE already requires pairing with a pairing code.
if bitbox02::communication_mode_ble_enabled() || already_verified {
state.set_pairing_verified()?;
usb_out.push(0); // let app know we don't require verification
} else {
Expand Down