Use crc32c crate #20
Closed
Use crc32c crate #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Note that it will be at least a few release cycles before I'd be willing to merge this. |
|
bump |
BurntSushi
added a commit
that referenced
this pull request
Feb 12, 2020
We avoid bring in another crate since the code to do this is so small and reasonably simple. Surprisingly, this results in fairly marginal performance gains. Closes #20
BurntSushi
added a commit
that referenced
this pull request
Feb 12, 2020
We avoid bring in another crate since the code to do this is so small and reasonably simple. Surprisingly, this results in fairly marginal performance gains. Closes #20
BurntSushi
added a commit
that referenced
this pull request
Feb 12, 2020
We avoid bring in another crate since the code to do this is so small and reasonably simple. Surprisingly, this results in fairly marginal performance gains. Closes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.27 added stable SIMD support. The
crc32ccrate has been updated to work on stable.This pull request replaces the crate's CRC32-Castagnoli implementation with the one from the
crc32ccrate.Fixes #19.
Note: since 1.27 has just been released, we might want to wait until some time passes so that users of this crate update their Rust compiler version.