Skip to content

Do Not Allow N/A as Product or Vendor #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jgamblin
Copy link

@jgamblin jgamblin commented Apr 9, 2025

Listening to Andrew Pollock at Vulncon say that nearly 20% of products and vendors are listed as n/a, this update to the schema stops that from being allowed.

jgamblin added 2 commits April 9, 2025 14:32
Does not allow n/a as the vendor or the product.
@jgamblin
Copy link
Author

jgamblin commented Apr 9, 2025

There are 2,595 CVEs published in the last 365 days that do not meet the minimal CVE publishing standards and should have not been published. This PR will no longer allow these CVEs to bypass the publishing rules by using n/a.

combined_na_product_vendor.csv

@attritionorg
Copy link

Big, big upvote for this! Hold CNAs accountable.

@zmanion
Copy link
Contributor

zmanion commented Apr 22, 2025

I'm in favor of better quality and standards. For those records with "n/a" do they provide vendor/product/version information in the prose description? One could argue that the requirement is met through the description or the affected JSON.

At a glance, yes, the "n/a" records do have vendor/product/version information in the descriptions. So preventing "n/a" would probably involve a rule change (e.g., MUST use affected orcpeApplicability or other appropriate JSON).

I believe these are the core requirements from the current rules:

5.1.3 MUST identify at least one affected Product using information such as Supplier and Product names, versions, and dates.

5.1.4 MUST identify at least one Product as “affected” or “unknown” (with the possibility of being affected).

5.1.7 MUST identify the type of Vulnerability. The CVE record SHOULD use CWE...

5.1.9 MUST contain a prose description (see 5.2).

5.1.10 MUST contain at least one public reference (see 5.3).

@attritionorg
Copy link

attritionorg commented Apr 22, 2025

There are CVEs published that consistently lack a vendor or product, and many that do not have versions.

Further, rule 5.1.10 has been violated more than once in the past year.

@jgamblin
Copy link
Author

Even if the rule permits the data to be included in the description, there remains a concern regarding data quality that needs to be addressed. If these fields are not mandatory, they should not be marked as required. Allowing "N/A" complicates overall data handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants