PAINTROID_457: Add .ora support for save/load #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakicelebi
requested changes
May 31, 2025
| for (var file in archive) { | ||
| if (file.isFile && | ||
| (file.name.endsWith('.png') || file.name.endsWith('.jpg')) || | ||
| file.name.endsWith('.ora')) { |
There was a problem hiding this comment.
Can ora files be nested? I think this check is redundant.
| import 'package:image/image.dart' as img; | ||
|
|
||
| class ProcessOra { | ||
| Future<List<ui.Image>> processOraFile(Archive archive) async { |
There was a problem hiding this comment.
You should be parsing the XML file for the correrct layer order.
| final savePath = await FilePicker.platform.saveFile( | ||
| dialogTitle: 'Save As', | ||
| fileName: filename, | ||
| bytes: data, // Required for Android/iOS |
| final file = | ||
| await File('$saveDirectory/$filename').create(recursive: true); | ||
| return Result.ok(await file.writeAsBytes(data)); | ||
| // File is already saved by file_picker |
| if (file.isFile && | ||
| (file.name.endsWith('.png') || file.name.endsWith('.jpg')) || | ||
| file.name.endsWith('.ora')) { | ||
| img.Image? decodedImage = img.decodeImage(file.content as List<int>); |
There was a problem hiding this comment.
If `decodeImage fails, this might silently skip it. More explicit error handling or logging here could be beneficial.
|
Ora support is too depedant on the layer system. Lets put this PR as draft and continue to work on it after layer PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAINTROID-457
New Features and Enhancements
.ora(OpenRaster) file formatRefactorings and Bug Fixes
.oracompatibility alongside existing formatscatrobat-imgformatChecklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.