-
Notifications
You must be signed in to change notification settings - Fork 344
Feature/notification refactor phase 1 #11157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Johnetordoff
wants to merge
19
commits into
CenterForOpenScience:feature/pbs-25-10
Choose a base branch
from
Johnetordoff:feature/notification-refactor-phase-1
base: feature/pbs-25-10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/notification refactor phase 1 #11157
Johnetordoff
wants to merge
19
commits into
CenterForOpenScience:feature/pbs-25-10
from
Johnetordoff:feature/notification-refactor-phase-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feature/osfgroup [ENG-7934] OSF Notifications Refactor
…/feature/ENG-7908-remove-meetings-comments-and-osf-groups-notifications [ENG-7908] Remove Meetings, Comments and OSF Groups Notifications
7bab04d
to
4892afb
Compare
…OpenScience/osf.io into feature/notification-refactor-phase-1 * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…hub.com/bodintsov/osf.io into feature/notification-refactor-phase-1 * 'feature/remove-remaining-quickiles-code' of https://github.com/bodintsov/osf.io: flake8 fixed tests remove quickfiles
05d1263
to
1a2f7c1
Compare
…ap-Zherebetskyi/osf.io into feature/notification-refactor-phase-1 * 'feature/remove_test_speed-up' of https://github.com/Ostap-Zherebetskyi/osf.io: update mails mock Update send_mail mocks
9fa911c
to
013d422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket