-
Notifications
You must be signed in to change notification settings - Fork 90
Resolved bug #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Resolved bug #557
Conversation
Hi @wjs123456, please provide more details about how to reproduce the problem you're seeing. Screenshots may help a lot! |
|
Sorry @wjs123456, I don't really follow you. You should avoid having missing tiles, right? And returning a "completed" status for a tile that doesn't exist seems wrong. So I don't what you're suggesting is wrong, what you're suggesting to change, or what that screenshot has to do with anything. Please describe it in as much detail as you can. If English is not your first language, feel free to use your native language and we will translate it. |
Hi @wjs123456, Could you please respond to Kevin's questions above? We'd like to triage this PR but without more information, we'll have to close it for inactivity. |
Closing due to inactivity. Feel free to reopen when you have more detail @wjs123456. |
I somehow missed that this is a PR, not an issue. So first of all, thank you for the PR @wjs123456! And second, I'm going to reopen it, because it's clear you're providing a solution to some problem, even if we don't completely understand what it is. We still need your help to get this merged, though. If you haven't signed the Contributor License Agreement already, please do that so that we can review this: And we could also still use a bit more detail about what problem you ran into that this PR is meant to solve. Thanks! |
Hi @wjs123456, we don't seem to have a signed CLA from you, and we can't review this without one. Because we haven't heard from you in awhile, I am going to close this PR. But if you're able to get back to this and sign the CLA, please feel free to reopen this pull request. We would definitely appreciate it. |
Sorry, I just noticed this information. I have signed the CLA. Please check it. |
Thanks @wjs123456, I can confirm we received the signed CLA. I'll reopen this PR and we'll review it soon. In the meantime, any additional background or details you can provide would go a long way toward getting it accepted! |
When offline terrain file not exist,cesium terrain mesh incomplete display