Skip to content

Resolved bug #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolved bug #557

wants to merge 1 commit into from

Conversation

wjs123456
Copy link

When offline terrain file not exist,cesium terrain mesh incomplete display

@kring
Copy link
Member

kring commented Mar 3, 2025

Hi @wjs123456, please provide more details about how to reproduce the problem you're seeing. Screenshots may help a lot!

@wjs123456
Copy link
Author

Hi @wjs123456, please provide more details about how to reproduce the problem you're seeing. Screenshots may help a lot!

截图
When Cesium Unity is loading offline terrain data and the local terrain data is missing at some levels, Unity's SendWebRequest will not return a completed status, which results in CesiumAsync::IAssetRequest having no way of knowing the tile acquisition status of the current level.

@kring
Copy link
Member

kring commented Mar 4, 2025

Sorry @wjs123456, I don't really follow you. You should avoid having missing tiles, right? And returning a "completed" status for a tile that doesn't exist seems wrong. So I don't what you're suggesting is wrong, what you're suggesting to change, or what that screenshot has to do with anything.

Please describe it in as much detail as you can. If English is not your first language, feel free to use your native language and we will translate it.

@j9liu
Copy link
Contributor

j9liu commented Mar 14, 2025

Hi @wjs123456,

Could you please respond to Kevin's questions above? We'd like to triage this PR but without more information, we'll have to close it for inactivity.

@kring
Copy link
Member

kring commented Mar 19, 2025

Closing due to inactivity. Feel free to reopen when you have more detail @wjs123456.

@kring kring closed this Mar 19, 2025
@kring
Copy link
Member

kring commented Mar 19, 2025

I somehow missed that this is a PR, not an issue. So first of all, thank you for the PR @wjs123456! And second, I'm going to reopen it, because it's clear you're providing a solution to some problem, even if we don't completely understand what it is.

We still need your help to get this merged, though. If you haven't signed the Contributor License Agreement already, please do that so that we can review this:
https://cesium.com/learn/cesium-native/ref-doc/contributing.html#md__2home_2runner_2work_2cesium-native_2cesium-native_2CONTRIBUTING

And we could also still use a bit more detail about what problem you ran into that this PR is meant to solve.

Thanks!

@kring kring reopened this Mar 19, 2025
@kring
Copy link
Member

kring commented Apr 22, 2025

Hi @wjs123456, we don't seem to have a signed CLA from you, and we can't review this without one. Because we haven't heard from you in awhile, I am going to close this PR. But if you're able to get back to this and sign the CLA, please feel free to reopen this pull request. We would definitely appreciate it.

@kring kring closed this Apr 22, 2025
@wjs123456
Copy link
Author

Hi @wjs123456, we don't seem to have a signed CLA from you, and we can't review this without one. Because we haven't heard from you in awhile, I am going to close this PR. But if you're able to get back to this and sign the CLA, please feel free to reopen this pull request. We would definitely appreciate it.

Sorry, I just noticed this information. I have signed the CLA. Please check it.

@kring
Copy link
Member

kring commented May 8, 2025

Thanks @wjs123456, I can confirm we received the signed CLA. I'll reopen this PR and we'll review it soon. In the meantime, any additional background or details you can provide would go a long way toward getting it accepted!

@kring kring reopened this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants