feat: deprecate --detach flag in forest #5652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
May 27, 2025
| @@ -7,10 +7,6 @@ source "$(dirname "$0")/harness.sh" | |||
|
|
|||
| forest_init_stateless | |||
|
|
|||
| echo "Verifying the heaviest tipset to be the genesis" | |||
There was a problem hiding this comment.
This has been changed in the new chain follower, Forest now follows chain head without any validation. it will fail on main if we sleep for a few seconds.
/// When `stateless_mode` is true, forest connects to the P2P network but
/// does not execute any state transitions. This drastically reduces the
/// memory and disk footprint of Forest but also means that Forest will not
/// be able to validate the correctness of the chain.
stateless_mode: bool,
hanabi1224
requested review from
LesnyRumcajs and
sudo-shashank
and removed request for
a team
CHANGELOG.md
Outdated
| @@ -43,6 +43,8 @@ | |||
|
|
|||
| ### Removed | |||
|
|
|||
| -[#5652](https://github.com/ChainSafe/forest/pull/5652) Remove `--detach` flag from `forest`. | |||
There was a problem hiding this comment.
Let's link to the README entry on this?
Comment on lines
+46
to
+47
| -[#5652](https://github.com/ChainSafe/forest/pull/5652) Remove `--detach` flag from `forest`. Checkout the [migration guide](https://github.com/ChainSafe/forest#detaching-forest-process) | ||
|
|
There was a problem hiding this comment.
I'd add it to the section of breaking changes for visibility.
LesnyRumcajs
approved these changes
May 28, 2025
sudo-shashank
approved these changes
May 28, 2025
hanabi1224
added a commit
that referenced
this pull request
May 28, 2025
4 tasks
hanabi1224
added a commit
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
--detachflag fromforest.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist