Stop enabling CONFIG_PPC_DISABLE_WERROR=y for clang-14+ #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need to wait on ClangBuiltLinux/linux#252 (the revert of the revert being accepted)? |
nickdesaulniers
approved these changes
Aug 28, 2023
Maybe? The build is already broken for |
ah, then I guess not. Merge away! |
Split up the ppc64 configuration into a "no -Werror" variant so that -Werror can be enabled for clang-14+. -Warray-bounds is only enabled for 5.18+, so we only need this configuration enabled for clang-13 and older on 6.1 and newer. Closes: ClangBuiltLinux#617 Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
force-pushed
the
ppc64-werror-update
branch
from
3ca39c8 to
47bbca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the ppc64 configuration into a "no
-Werror" variant so that-Werrorcan be enabled for clang-14+.-Warray-boundsis only enabled for 5.18+, so we only need this configuration enabled for clang-13 and older on 6.1 and newer.Closes: #617