Skip to content

Fix and reimplement: Expand cell height if there is only one row (Original #537, Revert #548) #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

natalyjazzviolin
Copy link
Contributor

Closes https://github.com/ClickHouse/control-plane/issues/12806

Why

If you run a command like show create table example_table, the row does not expand to show the full create table command.

What

This reverts PR #537 and fixes a syntax bug. It expands the row to the full height of the content:
https://github.com/user-attachments/assets/a6b73b97-490f-4ccd-abe2-ba98832bf4c4

To reproduce:

CREATE TABLE random_user_events (
    user_id UInt32,
    event_time DateTime,
    event_type Enum8('click' = 1, 'view' = 2, 'purchase' = 3),
    item_id String,
    price Decimal(10,2),
    quantity UInt16
) ENGINE = MergeTree()
ORDER BY (user_id, event_time)
PARTITION BY toYYYYMM(event_time)
SETTINGS index_granularity = 8192;

show create table random_user_events;    

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:06pm

@natalyjazzviolin natalyjazzviolin merged commit 72ecb3b into main Mar 3, 2025
6 checks passed
@natalyjazzviolin natalyjazzviolin deleted the nataly/fix/revert-537-syntax-error branch March 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants