[ClickPipes] FileUpload component
#576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjhampton
commented
Apr 2, 2025
•
pjhampton
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pjhampton
requested review from
hoorayimhelping,
gjones,
crisalbu and
natalyjazzviolin
crisalbu
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Great to see so much progress @pjhampton !
Can we please make the border: 1px dashed ? Only when a file hasn't been uploaded yet.
Also, can we remove the hover effect?
This background colour should only appear when you're dropping a file into the box.
How can I test the upload in progress state, and the upload successful/failed? When I use these handles, nothing changes.
ariser
reviewed
Apr 2, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Some adjustments Fix build Fix error propogation Update
pjhampton
force-pushed
the
pjhampton/file-uploader
branch
from
422c093 to
604594c
Compare
pjhampton
changed the title
FileUpload component
…hampton/file-uploader
gjones
reviewed
Apr 8, 2025
gjones
reviewed
Apr 8, 2025
gjones
reviewed
Apr 8, 2025
gjones
requested changes
Apr 8, 2025
gjones
reviewed
Apr 8, 2025
…hampton/file-uploader
…hampton/file-uploader
…hampton/file-uploader
gjones
approved these changes
Apr 10, 2025
ariser
reviewed
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.