-
Notifications
You must be signed in to change notification settings - Fork 11
Adding "thin" icon variants for <Icon /> component #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thelevicole
wants to merge
21
commits into
main
Choose a base branch
from
lc-icon-stroke-weights
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/click-ui into lc-icon-stroke-weights
…e/click-ui into lc-icon-stroke-weights
…support for icon weight
…e/click-ui into lc-icon-stroke-weights
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
weight
property to the<Icon />
component, allowing you to choose between different icon weights. The available values are:default
(Figma token path:click.image.borderWidth.default
)thin
(Figma token path:click.image.borderWidth.thin
)Internally, the weight property is applied with CSS by targeting SVG elements with a stroke width of 1.5. This approach is similar to how the
color
andstroke
properties are implemented, but it specifically targets a stroke width which is safe to change.Example usage: