MySQL pipe: data type mapping #3641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
serprex
reviewed
Apr 10, 2025
Comment on lines
27
to
28
| | Float | Float32 | May lose a bit of precision during initial load due to text protocols. | | ||
| | Double | Float64 | May lose a bit of precision during initial load due to text protocols. | |
There was a problem hiding this comment.
- precision issue should only impact initial load
- not sure if we want to have more care around language here
There was a problem hiding this comment.
Could you take a look now @serprex ?
serprex
reviewed
Apr 10, 2025
serprex
reviewed
Apr 10, 2025
serprex
reviewed
Apr 10, 2025
serprex
reviewed
Apr 10, 2025
serprex
reviewed
Apr 10, 2025
Co-authored-by: Philip Dubé <[email protected]>
Co-authored-by: Philip Dubé <[email protected]>
Co-authored-by: Philip Dubé <[email protected]>
Co-authored-by: Philip Dubé <[email protected]>
Co-authored-by: Philip Dubé <[email protected]>
Amogh-Bharadwaj
force-pushed
the
mysql-datatype-mapping
branch
from
5045bd0 to
f05a862
Compare
serprex
reviewed
Apr 11, 2025
serprex
approved these changes
Apr 11, 2025
Co-authored-by: Philip Dubé <[email protected]>
gingerwizard
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a table detailing data type support for MySQL
Checklist