Skip to content

RowBinary writer for ease of serialization #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 16, 2025
Merged

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Feb 28, 2025

Summary

  • Implements RowBinaryWriter to take data and serialize it in RowBinary format
  • Adds data type tests to validate changes

This will be used for #2171

Closes #2177

Checklist

Delete items not relevant to your PR:

  • Closes #
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Feb 28, 2025
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@Paultagoras Paultagoras marked this pull request as ready for review April 10, 2025 19:44
@mshustov mshustov requested a review from Copilot April 14, 2025 09:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@Paultagoras Paultagoras linked an issue Apr 16, 2025 that may be closed by this pull request
@Paultagoras Paultagoras merged commit 18ed07e into main Apr 16, 2025
25 checks passed
@Paultagoras Paultagoras deleted the row-binary-writer branch April 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not write data into table [client-v2] RowBinary writer
2 participants