Skip to content

[client-v2/jdbc-v2] Fix log spam #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

[client-v2/jdbc-v2] Fix log spam #2303

merged 1 commit into from
Apr 14, 2025

Conversation

patschl
Copy link
Contributor

@patschl patschl commented Apr 12, 2025

Summary

Took the liberty and removed another log statement that was also spamming heavily, along with the one mentioned in #2255.

Closes #2255

Checklist

Delete items not relevant to your PR:

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2025

CLA assistant check
All committers have signed the CLA.

@mshustov mshustov added this to the 0.8.4 milestone Apr 14, 2025
@mshustov mshustov requested review from chernser, Copilot and Paultagoras and removed request for Copilot April 14, 2025 07:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

jdbc-v2/src/main/java/com/clickhouse/jdbc/StatementImpl.java:48

  • [nitpick] Removing the schema log statement helps in reducing spam, but please verify that this information is captured elsewhere for debugging or auditing purposes.
LOG.info("Statement schema " + schema);

client-v2/src/main/java/com/clickhouse/client/api/internal/ClickHouseLZ4InputStream.java:132

  • Lowering the log level from warn to debug may hide significant buffer reallocation events that could impact performance; please confirm that this change is intentional.
LOG.debug("Buffer size is too small, reallocate buffer with size: {}", uncompressedSize);

Copy link
Contributor

@Paultagoras Paultagoras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing these out!

@Paultagoras Paultagoras merged commit 292d32a into ClickHouse:main Apr 14, 2025
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] ClickhouseLZ4OutputStream spams with warnings
4 participants