Skip to content

Cod 674 collect profiles while benchmarks are running #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Cod 674 collect profiles while benchmarks are running #92

merged 3 commits into from
Apr 25, 2025

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Mar 25, 2025 •
edited
Loading

TODO:

  • version bump to 2.10.0
  • criterion integration
  • common interface to start / stop benchmarks inside the compat crates

@codspeed-hq CodSpeed HQ

This comment was marked as outdated.

Sign in to view
@not-matthias not-matthias mentioned this pull request Mar 25, 2025
Merged
3 tasks
@codspeed-hq CodSpeed HQ

This comment was marked as outdated.

Sign in to view
GuillaumeLagrange
GuillaumeLagrange requested changes Mar 26, 2025
View reviewed changes
GuillaumeLagrange
GuillaumeLagrange approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olgtm

@not-matthias not-matthias force-pushed the cod-674-collect-profiles-while-benchmarks-are-running branch from 6acfcb8 to 788b13d Compare April 22, 2025 08:18
art049
art049 reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small question on the way we use guards everywhere otherwise pretty cool :)

@not-matthias not-matthias force-pushed the cod-674-collect-profiles-while-benchmarks-are-running branch from 788b13d to 4a1e2d2 Compare April 25, 2025 08:55
@not-matthias not-matthias force-pushed the cod-674-collect-profiles-while-benchmarks-are-running branch from 4a1e2d2 to b57122f Compare April 25, 2025 12:23
@not-matthias not-matthias force-pushed the cod-674-collect-profiles-while-benchmarks-are-running branch from b57122f to 9114511 Compare April 25, 2025 12:32
@not-matthias not-matthias merged commit 9114511 into main Apr 25, 2025
12 of 13 checks passed
@not-matthias not-matthias deleted the cod-674-collect-profiles-while-benchmarks-are-running branch April 25, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art049 art049 art049 left review comments

@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@not-matthias @art049 @GuillaumeLagrange