fix: sheet is too small, or might be displayed on the wrong window #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong window (or not displayed) #4
EchoEllet
commented
Jan 21, 2025
macos/native_image_picker_macos/Sources/native_image_picker_macos/ImagePickerImpl.swift
Outdated
Show resolved
Hide resolved
EchoEllet
commented
Jan 22, 2025
macos/native_image_picker_macos/Sources/native_image_picker_macos/ImagePickerImpl.swift
Show resolved
Hide resolved
EchoEllet
commented
Jan 22, 2025
macos/native_image_picker_macos/Sources/native_image_picker_macos/ImagePickerImpl.swift
Show resolved
Hide resolved
This was
linked to
issues
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing:
Currently, the
ImagePickerImpl.swiftcoverage is low but tests are planned and will be added (#6) before working on new features (e.g., #5).The Swift code will be refactored to be testable and we may refer to
file_selectorduring the process.PickerSheet.mov