-
Notifications
You must be signed in to change notification settings - Fork 373
Create cosmwasm-core
crate
#2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build for We can either:
I'm guessing there's not a lot to maintain since the crate just copied internal macros from the STL |
I would prefer that approach as it allows us to ensure the implementation serves our often-not-trivial needs. If you look at packages/std/src/forward_ref.rs we already have a place where those things can go. |
00882e6
to
eb021c8
Compare
For some reason the And it's one less dependency with the |
Last bit of bikeshedding: Do we want to remove the error cases of things that aren't handled in std anymore? Well, I would just go ahead and keep them since exhaustive matches are a niche usecase but removing cases could have major implications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
My main worry here is that looking at a bunch of details we can't easily hide away the extra crate from the contract developer, which means more comlpexity to handle for them. Not sure if there is anything we can do to improve the situation.
0be49cd
to
248ee3f
Compare
Looking at the codecov diff, it seems like the difference mostly stems from the fact that the |
For what it's worth, I think snapshot testing for the JSON schema is worthwhile, but IMO outside the scope of this PR. |
50d63e6
to
389e92b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
God, that rebase was something.. |
Oh good, the commit finally made it. GitHub really crashed for a bit there, huh? |
Co-authored-by: Christoph Otter <[email protected]>
Closes #2041
Rough draft for now. Some uglypoints, such as the weird
__internal
module definitely need bikeshedding.TODO:
From<&Vec>
for Binary and HexBinary #2036 (review))?